-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Dev-ops, N+1 offset, temporary directory #5
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look great!
The next item on the list is about .
Maybe after that item, I can try to run the test on my new computer and see if it works?
On my mac, I am currently seeing:
|
@frheault good that it is working now- yes, this command is included in the README The gtest should have been installed via conan, not sure why it didnt find |
@anibalsolon Was I doing something wrong or was the file in ./examples/load_trx.cpp not build? |
@anibalsolon Is there something I can run or test before of meeting this afternoon? |
@frheault not really- we may need to discuss some design decisions about the cpp implementation today |
This PR:
data
dir