Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: assign random dice side when null #49

Merged
merged 6 commits into from
Oct 1, 2024
Merged

feat: assign random dice side when null #49

merged 6 commits into from
Oct 1, 2024

Conversation

aeschi
Copy link
Collaborator

@aeschi aeschi commented Sep 26, 2024 •
edited
Loading

raphael-arce
raphael-arce reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to use a slightly different approach 👍

services/state/state.js Outdated Show resolved Hide resolved
raphael-arce
raphael-arce approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one detail in the type annotation, otherwise lgtm so far, will test it tomorrow 👍

services/rest/paths/pick-idea/pick-idea.js Outdated Show resolved Hide resolved
raphael-arce
raphael-arce approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question otherwise lgtm 👍

services/state/state.js Outdated Show resolved Hide resolved
@aeschi aeschi merged commit 79c5777 into main Oct 1, 2024
1 check passed
@aeschi aeschi deleted the feat/fallback-without-bt-connection branch October 1, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael-arce raphael-arce raphael-arce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeschi @raphael-arce