Issue #00000 chore: Updated language constants #429
Conversation
WalkthroughThe pull request involves modifications to the English (Great Britain) language files for the TJ Universal Content Manager (UCM) component. The changes focus on rephrasing success messages, refining labels, and ensuring consistent capitalization across various user-facing strings. These updates aim to enhance clarity and grammatical accuracy in the application's interface text, providing a more uniform presentation of messages for users. Changes
Detailed String Updates
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/com_tjucm/languages/administrator/en-GB/en-GB.com_tjucm.ini(2 hunks)
🔇 Additional comments (1)
src/components/com_tjucm/languages/administrator/en-GB/en-GB.com_tjucm.ini (1)
16-18: LGTM! Improved message clarity and consistency
The changes enhance readability by adopting a more natural English sentence structure, placing "successfully" at the end of the messages. This also maintains consistency with other success messages in the codebase.
| COM_TJUCM_NO_ITEM_SELECTED="No items selected" | ||
| COM_TJUCM_SAVE_SUCCESS="Item successfully saved" | ||
| COM_TJUCM_ITEM_ID_SELECT_LABEL="Select the item ID" | ||
| COM_TJUCM_SELECT_UCM_TYPE_LBL="UCM Type" | ||
| COM_TJUCM_SELECT_UCM_TYPE_DESC="Select UCM Type" | ||
| COM_TJUCM_FIELDSET_UCM_TYPE_SELECT_LABEL="UCM Config" | ||
| COM_TJUCM_FILTER_SELECT_LABEL=" - Select %s - " | ||
| COM_TJUCM_TEST_LABEL="Test label" | ||
| COM_TJUCM_FILTER_SELECT_LABEL=" - Choose %s - " |
There was a problem hiding this comment.
💡 Codebase verification
Consider maintaining consistency in selection-related labels
The review comment is valid. There is an inconsistency between the site and administrator language files:
- Administrator file uses "Choose" (
" - Choose %s - ") - Site file uses "Select" (
" - Select %s - ")
Additionally, all other selection-related labels in both files consistently use "Select":
COM_TJUCM_ITEM_ID_SELECT_LABELCOM_TJUCM_SELECT_UCM_TYPE_DESCCOM_TJUCM_SELECT_SOURCE_FORMCOM_TJUCM_FILTER_SELECT_CATEGORY_LABEL
etc.
Recommendation: Keep "Select" for consistency across all labels by reverting the change from "Select" to "Choose".
🔗 Analysis chain
Consider maintaining consistency in selection-related labels
While "Choose" is user-friendly, it creates inconsistency with other similar labels in the file that use "Select" (e.g., COM_TJUCM_ITEM_ID_SELECT_LABEL, COM_TJUCM_SELECT_UCM_TYPE_LBL). Consider either:
- Keeping "Select" for consistency, or
- Updating all selection-related labels to use "Choose"
Let's check for other selection-related labels in the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other selection-related labels
rg "SELECT_LABEL|Select|Choose" --type ini
Length of output: 72
Script:
#!/bin/bash
# Search for selection-related labels in all files
rg -l "SELECT_LABEL|Select|Choose"
Length of output: 918
Script:
#!/bin/bash
# Get content of the language file
cat src/components/com_tjucm/languages/administrator/en-GB/en-GB.com_tjucm.ini
Length of output: 10797
Script:
#!/bin/bash
# Search for similar labels in other language files
fd "\.ini$" | xargs rg "SELECT_LABEL|Select|Choose"
Length of output: 2389
| COM_TJUCM_FILTER_SELECT_LABEL=" - Select %s - " | ||
| COM_TJUCM_TEST_LABEL="Test label" | ||
| COM_TJUCM_FILTER_SELECT_LABEL=" - Choose %s - " | ||
| COM_TJUCM_TEST_LABEL="Test Label" |
There was a problem hiding this comment.
💡 Codebase verification
Inconsistent capitalization found in labels
The review comment is correct. There are multiple inconsistencies in capitalization across similar labels in both administrator and site language files:
- In administrator/en-GB/en-GB.com_tjucm.ini:
- COM_TJUCM_TYPES_MODIFIED_BY="Modified By" (uses title case)
- COM_TJUCM_TYPES_CREATED_BY="Created by" (doesn't use title case)
- COM_TJUCM_ITEMS_MODIFIED_BY="Modified by" (doesn't use title case)
- COM_TJUCM_ITEMS_CREATED_BY="Created by" (doesn't use title case)
- COM_TJUCM_FORM_LBL_TYPE_CREATED_BY="Created by" (doesn't use title case)
- COM_TJUCM_FORM_LBL_TYPE_MODIFIED_BY="Modified by" (doesn't use title case)
All similar labels should follow the same capitalization pattern for consistency.
🔗 Analysis chain
Ensure consistent capitalization across all labels
While the capitalization changes improve individual labels, there are still inconsistencies with similar labels in the file. Consider updating all role-based labels to use consistent title case:
- "Created by" → "Created By"
- "Modified by" → "Modified By"
Let's check for other inconsistent capitalizations:
Also applies to: 51-51
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for inconsistent capitalizations in role-based labels
rg "by$|By$" --type ini
Length of output: 53
Script:
#!/bin/bash
# Search for all labels containing "by" or "By" in language files
rg -i "by\"$|By\"$" src/components/com_tjucm/languages/
Length of output: 1903
Script:
#!/bin/bash
# Get all content from the specific language file to analyze capitalization patterns
cat src/components/com_tjucm/languages/administrator/en-GB/en-GB.com_tjucm.ini
Length of output: 10797
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/com_tjucm/languages/site/en-GB/en-GB.com_tjucm.ini (1)
200-200: Standardize action verbs across the interfaceWhile the changes improve clarity, there's inconsistency in the use of "Select" vs "Choose":
- Line 219: "Select Copy To"
- Line 220: "Select Cluster"
Consider standardizing to "Choose" throughout:
-COM_TJUCM_COPY_ITEMS_SELECT_UCM_TYPE="Select Copy To" +COM_TJUCM_COPY_ITEMS_SELECT_UCM_TYPE="Choose Copy To" -COM_TJUCM_COPY_ITEMS_SELECT_CLUSTER="Select Cluster" +COM_TJUCM_COPY_ITEMS_SELECT_CLUSTER="Choose Cluster"Also applies to: 205-205, 207-208, 213-214
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/com_tjucm/languages/site/en-GB/en-GB.com_tjucm.ini(7 hunks)
🔇 Additional comments (5)
src/components/com_tjucm/languages/site/en-GB/en-GB.com_tjucm.ini (5)
2-2: LGTM! Improved message clarity
The changes enhance readability and maintain a professional tone:
- Success message is now more specific and complete
- Delete confirmation message is grammatically correct
Also applies to: 13-13
87-87: LGTM! Consistent terminology
The changes maintain consistency in terminology and improve clarity:
- Added helpful description for type title
- Consistent use of "Not Applicable" instead of "N/A"
- Proper capitalization in labels
Also applies to: 98-98, 100-100, 102-102
181-186: LGTM! Clear validation messages
The new validation messages are well-structured and provide clear feedback:
- Specific error messages for different validation scenarios
- Professional tone in error communication
222-222: LGTM! Clear success message
The message clearly confirms the action's success and follows the established pattern.
225-225: LGTM! Consistent with other filter labels
The label follows the established pattern of using "Choose" for selection controls.
| COM_TJUCM_ITEMS_CATEGORY_ID="Category ID" | ||
| COM_TJUCM_ITEMS_TYPE_ID="Type ID" | ||
| COM_TJUCM_ITEMS_CHECKED_OUT="Not Applicable" | ||
| COM_TJUCM_ITEMS_CHECKED_OUT_TIME="Not Applicable" | ||
| COM_TJUCM_ITEMS_CREATED_BY="Created By" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Ensure consistent capitalization across all similar labels
While these changes improve consistency within this section, there are inconsistencies with similar labels elsewhere in the file:
- Line 120: "Created by" vs "Created By"
- Line 123: "Type Id" vs "Type ID"
Consider updating these related strings for consistency:
-COM_TJUCM_FORM_LBL_ITEM_CREATED_BY="Created by"
+COM_TJUCM_FORM_LBL_ITEM_CREATED_BY="Created By"
-COM_TJUCM_FORM_LBL_ITEM_TYPE_ID="Type Id"
+COM_TJUCM_FORM_LBL_ITEM_TYPE_ID="Type ID"Committable suggestion skipped: line range outside the PR's diff.
Summary by CodeRabbit