-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #158773 chore: Rating Field in TjUcm #363
Open
shraddhaSankpal27
wants to merge
5
commits into
techjoomla:release-1.2.4
Choose a base branch
from
shraddhaSankpal27:release-1.2.4
base: release-1.2.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−4
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7acb3f1
Feature #158773 chore: Rating Field in TjUcm
prvnpuri 6a44d9a
Feature #163832 chore: Implement Multiple Copy feature on the fronten…
shraddhaSankpal27 de8fb89
Feature #163832 chore: Implement Multiple Copy feature on the fronten…
shraddhaSankpal27 3337d46
Feature #158773 chore: Rating Field in TjUcm
shraddhaSankpal27 cfbe468
Feature #158773 chore: Rating Field in TjUcm
shraddhaSankpal27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shraddhaSankpal27 direct CSS for bootstrap classes are not recommended, use UCM wrapper class with the CSS class.
e.g .ucm-wrapper .label{
CSS
}
Again, this can cause issues in other fields label and ieldsets. We should not write CSS for generic classes of bootstrap. The input and label should use template CSS only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankush-maherwal I'll update with help of designer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankush-maherwal @shraddha : Update the generic css for rating and also rating star use
images that will good option.