Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task #114679 refactor: [User Plugin] - Resolved Phpcs error and code … #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Pratikshakhandagale
Copy link
Contributor

…updated

@Pratikshakhandagale Pratikshakhandagale changed the title Task #114679 Refactor: [User Plugin] - Resolved Phpcs error and code … Task #114679 refactor: [User Plugin] - Resolved Phpcs error and code … Dec 9, 2017
}

/**
* Method to get groups list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update desc.

public function post()
{
$this->plugin->setResponse( JText::_( 'PLG_API_USERS_UNSUPPORTED_METHOD_POST' ));
$this->plugin->setResponse(JText::_('PLG_API_USERS_UNSUPPORTED_METHOD_POST'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do it like

$this->plugin->err_code		= 405;
$this->plugin->err_message	= JText::_('PLG_API_USERS_GET_METHOD_NOT_ALLOWED_MESSAGE');
$this->plugin->setResponse(null);```


return;
}
$this->plugin->setResponse(JText::_('PLG_API_USERS_IN_DELETE_FUNCTION_MESSAGE'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolbung @Pratikshakhandagale why did we remove delete code.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe because it wasn't robust. The plugin triggers weren't firing or something.. dont remember now. But ok if we can verify and bring it back.

However the bigger problem with this resource is that it's hardwired to work with Easysocial. That needs to be fixed.

Copy link
Member

@manojLondhe manojLondhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to comments for changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants