🔀 :: (#82) 공지사항 알람 버그 해결 (#227)

* ♻️ :: 리턴타입 nullable 설정 * ♻️ :: ? 삭제 * ♻️ :: 객체로 보내는 로직 삭제 * ♻️ :: 객체 로직으로 재변경 * ♻️ :: 안 쓰는 import 삭제 * ♻️ :: 클래스명 변경
team-xquare · Jun 2, 2023 · bada46c · bada46c
1 parent ccb198c
commit bada46c
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 16 deletions.
diff --git a/...on-domain/src/main/kotlin/io/github/v1servicenotification/detail/spi/PostDetailUserSpi.kt b/...on-domain/src/main/kotlin/io/github/v1servicenotification/detail/spi/PostDetailUserSpi.kt
@@ -3,7 +3,7 @@ package io.github.v1servicenotification.detail.spi
 import java.util.UUID
 
 interface PostDetailUserSpi {
-    fun getExcludeUserIdList(userIdList: List<UUID>?): List<UUID>
+    fun getExcludeUserIdList(userIdList: List<UUID>): List<UUID>
     fun getDeviceToken(userId: UUID): String
     fun getDeviceTokenList(userIdList: List<UUID>): List<String>
 }
diff --git a/notification-domain/src/main/kotlin/io/github/v1servicenotification/stubs/InMemoryUser.kt b/notification-domain/src/main/kotlin/io/github/v1servicenotification/stubs/InMemoryUser.kt
@@ -11,7 +11,7 @@ class InMemoryUser: PostDetailUserSpi {
         this.userId = userId
     }
 
-    override fun getExcludeUserIdList(userIdList: List<UUID>?): List<UUID> {
+    override fun getExcludeUserIdList(userIdList: List<UUID>): List<UUID> {
         return listOf(userId)
     }
 

diff --git a/...io/github/v1servicenotification/domain/user/domain/repository/CustomPostDetailUserImpl.kt b/...io/github/v1servicenotification/domain/user/domain/repository/CustomPostDetailUserImpl.kt
@@ -2,7 +2,7 @@ package io.github.v1servicenotification.domain.user.domain.repository
 
 import io.github.v1servicenotification.detail.spi.PostDetailUserSpi
 import io.github.v1servicenotification.infrastructure.feign.client.UserClient
-import io.github.v1servicenotification.infrastructure.feign.client.dto.request.ExcludeUserIdsRequest
+import io.github.v1servicenotification.infrastructure.feign.client.dto.request.GetExcludeUserIdsRequest
 import io.github.v1servicenotification.infrastructure.feign.error.FeignBadRequestException
 import org.springframework.stereotype.Component
 import java.util.UUID
@@ -11,8 +11,8 @@ import java.util.UUID
 class CustomPostDetailUserImpl(
     private val userClient: UserClient
 ) : PostDetailUserSpi {
-    override fun getExcludeUserIdList(userIdList: List<UUID>?): List<UUID> {
-        val userIdsRequest = ExcludeUserIdsRequest(userIdList)
+    override fun getExcludeUserIdList(userIdList: List<UUID>): List<UUID> {
+        val userIdsRequest = GetExcludeUserIdsRequest(userIdList)
         return userClient.getExcludeUserIdList(userIdsRequest).userIdList
     }
 

diff --git a/...src/main/kotlin/io/github/v1servicenotification/infrastructure/feign/client/UserClient.kt b/...src/main/kotlin/io/github/v1servicenotification/infrastructure/feign/client/UserClient.kt
@@ -1,6 +1,6 @@
 package io.github.v1servicenotification.infrastructure.feign.client
 
-import io.github.v1servicenotification.infrastructure.feign.client.dto.request.ExcludeUserIdsRequest
+import io.github.v1servicenotification.infrastructure.feign.client.dto.request.GetExcludeUserIdsRequest
 import io.github.v1servicenotification.infrastructure.feign.client.dto.response.TokenResponse
 import io.github.v1servicenotification.infrastructure.feign.client.dto.response.UserIdListResponse
 import org.springframework.cloud.openfeign.FeignClient
@@ -16,5 +16,5 @@ interface UserClient {
     fun token(@RequestParam("users") userList: List<UUID>): TokenResponse
 
     @GetMapping("/users/exclude")
-    fun getExcludeUserIdList(@RequestBody request: ExcludeUserIdsRequest): UserIdListResponse
+    fun getExcludeUserIdList(@RequestBody request: GetExcludeUserIdsRequest): UserIdListResponse
 }
diff --git a/...ub/v1servicenotification/infrastructure/feign/client/dto/request/ExcludeUserIdsRequest.kt b/...ub/v1servicenotification/infrastructure/feign/client/dto/request/ExcludeUserIdsRequest.kt
diff --git a/...v1servicenotification/infrastructure/feign/client/dto/request/GetExcludeUserIdsRequest.kt b/...v1servicenotification/infrastructure/feign/client/dto/request/GetExcludeUserIdsRequest.kt
@@ -0,0 +1,7 @@
+package io.github.v1servicenotification.infrastructure.feign.client.dto.request
+
+import java.util.UUID
+
+data class GetExcludeUserIdsRequest(
+    val userIdList: List<UUID>,
+)