Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ENGDESK-26634): add custom headers to invite and answer messages #338

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

DeividVeloso
Copy link
Contributor

@DeividVeloso DeividVeloso commented Nov 21, 2023

  • add custom headers to invite and answer messages

πŸ“ To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

βœ‹ Manual testing

  1. navigate to packages/js
  2. run yarn build and yarn link
  3. go to a webrtc project example and run yarn link @telnyx/webrtc
  4. go to call.newCall({ customHeaders: [ { name: 'X-INVITE-Call', value: '9999999', }, ]})
  5. check if this customer header shows on telnyx.rtc_invite WS message.
  6. go to call.answer({ customHeaders: [ { name: 'X-Answer-Call', value: '9999999', }, ], })
  7. check if this customer header shows on telnyx.rtc_answer WS message.

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

πŸ“Έ Screenshots

Description Screenshot
Desktop
usage.gif

@DeividVeloso DeividVeloso changed the title Engdesk 26634 feat(ENGDESK-26634): add custom headers to invite and answer messages Nov 21, 2023
@DeividVeloso DeividVeloso marked this pull request as ready for review November 21, 2023 16:53
@DeividVeloso DeividVeloso merged commit 69814b4 into main Nov 22, 2023
2 checks passed
@DeividVeloso DeividVeloso deleted the ENGDESK-26634 branch November 22, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants