remove prefix from markdown slugify, normalize name with backlinks to avoid dups #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
vojto
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Before approving I would run this by @maccman since he added the prefix in the first place.
On my end, I rely on those prefixes for debugging - when I want to find out how many notes user imported.
But people don't do large imports from Markdown, only Roam or Readwise, so I don't need these prefixes - but would like to keep them for other importers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s currently a discrepancy between import note
ids, which were prefixed withmdand slugified in a different way than backlink ids, ie a parsed note with the nameAlex MacCawwill have anoteIdofmd-alex-mac-caw, and another note that references[[Alex MacCaw]]will have a generated backlink ID ofalexmaccaw, which can cause duplicates upon iimport.This normalizes them to the current backlink ID (both will show as
alexmaccaw, which allows avoiding duplicates in the main repo + allows replacing backlinkhtmlin a way that links any imported backlinks to the appropriate DB note.