NABI-258--FIX: cursor pagination #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .orderBy( | ||
| QueryDslUtil.getOrderSpecifier( | ||
| Sort.by( | ||
| Sort.Order.desc("modifiedDate"), |
There was a problem hiding this comment.
p3
어느곳은 Sort 기준이 createdDate고, 어느곳은 modifiedDate인데요 ! 일관성을 가져갈 순 없는건가요 ??
There was a problem hiding this comment.
이 부분은 거래 성사 요청에 대한 부분이고, 거래 성사 같은 경우, 성사까지 이루어지는 시점으로 정렬 기준을 잡는 것이 좋아보여서 modifiedDate로 잡아두었다고 합니다.
From. 예진
born-A
approved these changes
Nov 20, 2023
BeommoKoo-dev
approved these changes
Nov 20, 2023
# Conflicts: # src/main/java/org/prgrms/nabimarketbe/domain/card/api/CardController.java # src/main/java/org/prgrms/nabimarketbe/domain/card/repository/CardRepositoryCustom.java # src/main/java/org/prgrms/nabimarketbe/domain/card/repository/CardRepositoryImpl.java
…agination' into NABI-258--junhyuk--fix--cursor-pagination # Conflicts: # src/main/java/org/prgrms/nabimarketbe/domain/card/api/CardController.java # src/main/java/org/prgrms/nabimarketbe/domain/card/repository/CardRepositoryCustom.java # src/main/java/org/prgrms/nabimarketbe/domain/card/repository/CardRepositoryImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tech spec: https://www.notion.so/prgrms/Tech-Spec-refactor-696693d775914ee5af6ab05f3a01f338?pvs=4
PR 확인 항목
PR 보내기전에 아래 항목들을 만족 하였는지 체크 해주세요
PR 종류
어떤 종류의 PR인지 아래 항목중에 체크 해주세요
어떤 기능이 추가 되었나요?
Issue Number: NABI - 258
기존에 있던 기능에 영향을 주나요?
기타