Nabi 41 yejin refactor kakao login user #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
50
to
52
| User user = optionalUser.orElseGet(() -> { | ||
| return userRepository.save(userSignInRequestDTO.toEntity()); | ||
| }); |
There was a problem hiding this comment.
p1
랜덤닉네임 생성 기능을 위해서 제가 만들어둔 signup메소드를 오버라이딩하는 것이 좋을 것 같습니다. (signup내부적으로 random nickname을 생성해주므로)
| return userRepository.save(userSignInRequestDTO.toEntity()); | ||
| }); | ||
|
|
||
| TokenDTO tokenDTO = jwtProvider.createTokenDTO(user.getUserId(), user.getRole()); |
There was a problem hiding this comment.
p1
TokenDTO클래스는 네이밍이 애매해서, 제가 TokenResponseDTO로 고친 이후 dev에 머지해두었습니다.
PR 날리기 전에 dev브랜치의 커밋을 머지하시는 것이 좋을 것 같아요! (해당 PR머지시 기존 파일들이 덮어씌워짐)
BeommoKoo-dev
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 확인 항목
PR 보내기전에 아래 항목들을 만족 하였는지 체크 해주세요
PR 종류
어떤 종류의 PR인지 아래 항목중에 체크 해주세요
어떤 기능이 추가 되었나요?
Issue Number: 41
기존에 있던 기능에 영향을 주나요?
기존 jwt 토큰만 내려주던 방식에서 유저 정보도 내려주도록 수정했습니다 !
실제 운영 환경에서 반환하는 응답 -- 23.11.07(화)
{
"code":"SUCCESS",
"message":"성공하였습니다.",
"userInfo":{
"userId":1,
"accountId":"3136155024",
"nickName":"신예진",
"imageUrl":null,
"role":"ROLE_USER",
"createdDate":"2023-11-07T18:11:01",
"modifiedDate":"2023-11-07T18:11:01"
},
"token": {
"grantType":"Bearer",
"accessToken":"",
"refreshToken":"",
"accessTokenExpireDate":3600000
}
}
기타