Merge pull request #53 from team-nabi/NABI-261--yejin--fix--suggestio…

…n-available-list Nabi-261--fix : 썸네일에 null 이 들어가는 이슈 해결
team-nabi · Nov 20, 2023 · 7f0f7af · 7f0f7af
2 parents 52a7c48 + 44f0454
commit 7f0f7af
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/...java/org/prgrms/nabimarketbe/domain/card/dto/response/projection/CardInfoResponseDTO.java b/...java/org/prgrms/nabimarketbe/domain/card/dto/response/projection/CardInfoResponseDTO.java
@@ -8,7 +8,7 @@
 public class CardInfoResponseDTO {
     private Long cardId;
 
-    private String thumbNail;
+    private String thumbnail;
 
     private String cardTitle;
 

diff --git a/src/main/java/org/prgrms/nabimarketbe/domain/card/service/CardService.java b/src/main/java/org/prgrms/nabimarketbe/domain/card/service/CardService.java
@@ -325,6 +325,7 @@ public List<CardSuggestionResponseDTO> getSuggestionResultCardList(
         if (pokeAvailable) {
             return parseCardListWithPokeAndOffer(cardList, priceRange);
         }
+
         return parseCardListWithOnlyOffer(cardList, priceRange);
     }
 
@@ -342,10 +343,19 @@ private List<CardSuggestionResponseDTO> parseCardListWithPokeAndOffer(
     ) {
         return cardList.stream()
             .peek(cardSuggestionResponseDTO -> {
-                if (targetPriceRange.isHigherThan(cardSuggestionResponseDTO.getCardInfo().getPriceRange())) {
-                    cardSuggestionResponseDTO.getSuggestionInfo().updateSuggestionType(SuggestionType.POKE);
+                if (targetPriceRange.isHigherThan(
+                    cardSuggestionResponseDTO
+                        .getCardInfo()
+                        .getPriceRange()
+                    )
+                ) {
+                    cardSuggestionResponseDTO
+                        .getSuggestionInfo()
+                        .updateSuggestionType(SuggestionType.POKE);
                 } else {
-                    cardSuggestionResponseDTO.getSuggestionInfo().updateSuggestionType(SuggestionType.OFFER);
+                    cardSuggestionResponseDTO
+                        .getSuggestionInfo()
+                        .updateSuggestionType(SuggestionType.OFFER);
                 }
             }).toList();
     }
@@ -355,14 +365,18 @@ private List<CardSuggestionResponseDTO> parseCardListWithOnlyOffer(
         PriceRange priceRange
     ) {
         List<CardSuggestionResponseDTO> offerOnlyCardList = cardList.stream()
-            .filter(cardSuggestionResponseDTO ->
-                cardSuggestionResponseDTO.getCardInfo()
+            .filter(
+                cardSuggestionResponseDTO -> cardSuggestionResponseDTO
+                    .getCardInfo()
                     .getPriceRange()
-                    .isHigherThan(priceRange))
+                    .isHigherThan(priceRange)
+            )
             .toList();
 
         offerOnlyCardList.forEach(offerCard ->
-            offerCard.getSuggestionInfo().updateSuggestionType(SuggestionType.OFFER));
+            offerCard
+                .getSuggestionInfo()
+                .updateSuggestionType(SuggestionType.OFFER));
 
         return offerOnlyCardList;
     }