🎉 getItems, itemHandler 구현 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaoong
reviewed
Nov 3, 2023
| const queryString = req.url.search | ||
| const cursorId = queryString.slice(10) | ||
| const currentPage = Number(cursorId) | ||
| const PAGE_SIZE = 5 |
There was a problem hiding this comment.
PAGE_SIZE는 한 번 당 불러오는 개수인가요?
요거 백엔드에서 정의하는게 아니라 요청할 때 같이 보내줘야 하는 것으로 기억하는데 바뀌었나요?
There was a problem hiding this comment.
명세에는 없어서, 일단 이렇게 작성 했는데
실 API 완성되고 적용될때 다시 pr open해서 적용하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호: 61
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)