Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ fetch class 사용 변경 #28

Merged
merged 1 commit into from
Nov 1, 2023
Merged

✨ fetch class 사용 변경 #28

merged 1 commit into from
Nov 1, 2023

Conversation

oaoong
Copy link
Collaborator

@oaoong oaoong commented Nov 1, 2023

- 목적

관련 티켓 번호: 77


- 주요 변경 사항

  • fetchAPI class를 이용한 context 삭제
  • fetch instance를 apiClient.ts에서 불러와 사용하도록 변경

기타 사항 (선택)

  • wiki에 수정 내용을 반영하겠습니다.

- 스크린샷 (선택)

@oaoong oaoong added the D-0 label Nov 1, 2023
@oaoong oaoong self-assigned this Nov 1, 2023
juyeon-park
juyeon-park approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@juyeon-park juyeon-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 Fetch 관련 클래스를 전역으로 관리하려던 FetchProvider가 사라지고 apiClient불러서 사용하는 변경사항으로 이해했습니다! 고생하셨습니다 따봉 👍

@oaoong oaoong merged commit 614b690 into develop Nov 1, 2023
2 checks passed
@oaoong oaoong deleted the NABI-77 branch November 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juyeon-park juyeon-park juyeon-park approved these changes

@doggopawer doggopawer Awaiting requested review from doggopawer

Assignees

@oaoong oaoong

Labels
D-0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oaoong @juyeon-park