🎉 Select 컴포넌트 추가 #21
Merged
🎉 Select 컴포넌트 추가 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaoong
reviewed
Oct 31, 2023
src/components/ui/Select/Select.tsx
Outdated
Comment on lines
83
to
84
| `relative flex w-full cursor-default select-none items-center rounded-sm py-1.5 pl-8 pr-2 text-sm outline-none focus:bg-accent focus:text-accent-foreground data-[disabled]:pointer-events-none data-[disabled]:opacity-50 hover:bg-primary-color opacity-20 rounded-md`, | ||
| className, |
There was a problem hiding this comment.
아직 저희 프로젝트 색상으로 수정이 안 된 것 같습니다!
There was a problem hiding this comment.
hover:bg-primary-color opacity-20 rounded-md 이렇게 하는거 아닌가요?
There was a problem hiding this comment.
focus:text-accent-foreground, focus:bg-accent 요런 것들도 수정 부탁드립니다!
There was a problem hiding this comment.
해당 내용 수정하여 최대한 figma 명세랑 비슷하게 만들었습니다!
juyeon-park
reviewed
Oct 31, 2023
src/components/ui/Select/Select.tsx
Outdated
| )) | ||
| SelectItem.displayName = SelectPrimitive.Item.displayName | ||
|
|
||
| const SelectSeparator = React.forwardRef< |
There was a problem hiding this comment.
저희가 쓰는 컴포넌트에서 SelectSeparator는 없어도 될 것 같아요!
src/components/ui/Select/Select.tsx
Outdated
| <SelectPrimitive.Trigger | ||
| ref={ref} | ||
| className={cn( | ||
| 'flex h-10 w-full items-center justify-between rounded-md border border-input bg-background px-3 py-2 text-sm ring-offset-background placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50', |
There was a problem hiding this comment.
text-muted-foreground는 혹시 저희가 쓰는 컬러인가요? 🤔
There was a problem hiding this comment.
아니요! 저는 원래 컴포넌트에서 Select의 className에 "hover:bg-primary-color opacity-20 rounded-md" 이 부분만 추가했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호:29
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)