Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 전체 레이아웃 설정 #15

Merged
merged 1 commit into from
Oct 31, 2023
Merged

🎉 전체 레이아웃 설정 #15

merged 1 commit into from
Oct 31, 2023

Conversation

oaoong
Copy link
Collaborator

@oaoong oaoong commented Oct 30, 2023

- 목적

관련 티켓 번호: 73


- 주요 변경 사항

  • 페이지 크기 상한, 하한 설정
  • nav 등에 대한 variable 설정

기타 사항 (선택)


- 스크린샷 (선택)

image

@oaoong oaoong added the D-1 label Oct 30, 2023
@oaoong oaoong self-assigned this Oct 30, 2023
@@ -68,7 +68,7 @@ const DropdownMenuContent = React.forwardRef<
ref={ref}
sideOffset={sideOffset}
className={cn(
'z-50 min-w-[8rem] overflow-hidden rounded-md border bg-background-color p-1 text-text-color shadow-md',
'z-50 absolute min-w-[8rem] overflow-hidden rounded-md border bg-background-color p-1 text-text-color shadow-md',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolute를 추가한 이유가 뭔가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레이아웃 밀려서 이것저것 시도할 때 넣었던 것 같네요. 다른 컴포넌트에 영향을 주지 않게하기 위해 했습니다

@doggopawer
Copy link
Contributor

LGTM

@oaoong oaoong merged commit 3c14204 into develop Oct 31, 2023
2 checks passed
@oaoong oaoong deleted the NABI-73 branch October 31, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants