Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#176) splash ๋กœ์ง ์ˆ˜์ • #177

Merged
merged 6 commits into from
Sep 3, 2023
Merged

๐Ÿ”€ :: (#176) splash ๋กœ์ง ์ˆ˜์ • #177

merged 6 commits into from
Sep 3, 2023

Conversation

ImGaram
Copy link
Member

@ImGaram ImGaram commented Sep 2, 2023

๐Ÿ’ก ๊ฐœ์š”

  • ๋กœ๊ทธ์ธ ๋กœ์ง ์†๋ณด๊ธฐ

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • splash ๋กœ์ง์„ ๋กœ๊ทธ์ธ ์ƒํƒœ์— ๋”ฐ๋ผ์„œ ๋กœ์ง์ด ์ˆ˜ํ–‰๋˜๊ฒŒ ์ˆ˜์ •ํ•˜์˜€์Œ.(observeLogin ํ•จ์ˆ˜์—์„œ isLogin ์ƒํƒœ์— ๋”ฐ๋ผ์„œ ์ฒ˜๋ฆฌ๋˜๊ฒŒ ์ˆ˜์ •ํ•จ.)
  • ๋กœ๊ทธ์ธ์ด ๋˜์–ด ์žˆ์œผ๋ฉด splash์—์„œ profile api๋ฅผ ํ˜ธ์ถœํ•˜๋Š”๋ฐ, main activity์—์„œ putExtra๋กœ ๋ฐ›์•„์„œ api ํ˜ธ์ถœ์„ ์ตœ์†Œํ™”ํ•˜๊ธฐ ์œ„ํ•ด profile data๋ฅผ ๋ฐ›์•„์™€ ์‚ฌ์šฉํ•˜๋Š” ๋กœ์ง์„ ๋งŒ๋“ค์—ˆ์Œ.

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • localDateTime format pattern ๋ณ€๊ฒฝ
  • ํ•„์š”์—†์–ด์ง„ profile response accountIdx ์‚ญ์ œ
  • splash ๋กœ์ง ๋ณ€๊ฒฝ
  • main screen์—์„œ profile data ๋ฐ›์•„์™€ ์‚ฌ์šฉํ•˜๋Š” ๋กœ์ง ์ƒ์„ฑ

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

@ImGaram ImGaram added the fix ์˜ค๋ฅ˜ ์ˆ˜์ • label Sep 2, 2023
@ImGaram ImGaram self-assigned this Sep 2, 2023
@ImGaram ImGaram linked an issue Sep 2, 2023 that may be closed by this pull request
(#176) :: splash ๋กœ์ง ์ˆ˜์ • #176
Closed
@ImGaram ImGaram merged commit 152c5a2 into develop Sep 3, 2023
1 check passed
@ImGaram ImGaram deleted the feature/176_splash_fix branch September 3, 2023 07:27
@ImGaram ImGaram restored the feature/176_splash_fix branch September 3, 2023 07:28
@ImGaram ImGaram deleted the feature/176_splash_fix branch October 8, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cjsghkd Cjsghkd Cjsghkd approved these changes

@wjdcksdn wjdcksdn Awaiting requested review from wjdcksdn

@Chaejongin12 Chaejongin12 Awaiting requested review from Chaejongin12

Assignees

@ImGaram ImGaram

Labels
fix ์˜ค๋ฅ˜ ์ˆ˜์ •
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(#176) :: splash ๋กœ์ง ์ˆ˜์ •
2 participants
@ImGaram @Cjsghkd