Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunderbird-Send localization #14

Merged
merged 12 commits into from
May 23, 2024
Merged

Thunderbird-Send localization #14

merged 12 commits into from
May 23, 2024

Conversation

DenB10
Copy link
Contributor

@DenB10 DenB10 commented May 22, 2024

Localizer submodule not added

Fixes #13

@tdulcet tdulcet added the enhancement New feature or request label May 23, 2024
@tdulcet
Copy link
Owner

tdulcet commented May 23, 2024

Thank you for the pull request! 🙏

I pushed a commit to add the Localizer submodule, as well as a few additional strings for the options and account management pages. As soon as you are able to translate those strings, I believe this is ready to be merged. Thanks again for all your work!

That's it.
That's it.
Sorry for the omissions and implementation errors, especially in the background.js file.
@DenB10
Copy link
Contributor Author

DenB10 commented May 23, 2024

Sorry for the few forgotten strings I didn't see the need for when using the add-on!
The translation is done (commit "Update messages.json").
Sorry also for my implementation errors in the "background.js" file! ☹️
Anyway, I'm happy to contribute to your project. 😉

Copy link
Owner

@tdulcet tdulcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, most of those strings are not obvious, as they are defined in the library. I am not sure if any organizations are actually using that managed options feature, but it is supported. I will add the needed HTML code to the option and account management pages in a follow up commit, so that they list the translator.

Anyway, thanks again for all your efforts. It was a pleasure working with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization proposal
2 participants