Fix knative-extensions#626 Do no affect Redis Config nor TLS Config i…

…f they are nil
tdeverdiere · Oct 21, 2024 · 8f2077b · 8f2077b
1 parent 4fd4e47
commit 8f2077b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/pkg/sink/reconciler/streamsink/streamsink.go b/pkg/sink/reconciler/streamsink/streamsink.go
@@ -95,7 +95,8 @@ func (r *Reconciler) updateTLSSecret(ctx context.Context, secret *corev1.Secret)
 	tlsSecret, err := GetTLSSecret(secret.Data)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Error reading TLS configuration", zap.Error(err))
+	} else {
+		// For now just override the previous config.
+		r.tlsCert = tlsSecret.TLSCertificate
 	}
-	// For now just override the previous config.
-	r.tlsCert = tlsSecret.TLSCertificate
 }
diff --git a/pkg/source/reconciler/streamsource/streamsource.go b/pkg/source/reconciler/streamsource/streamsource.go
@@ -127,16 +127,18 @@ func (r *Reconciler) updateRedisConfig(ctx context.Context, configMap *corev1.Co
 	redisConfig, err := GetRedisConfig(configMap.Data)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Error reading Redis configuration", zap.Error(err))
-	}
-	// For now just override the previous config.
-	r.numConsumers = redisConfig.NumConsumers
+	} else {
+        // For now just override the previous config.
+        r.numConsumers = redisConfig.NumConsumers
+    }
 }
 
 func (r *Reconciler) updateTLSSecret(ctx context.Context, secret *corev1.Secret) {
 	tlsSecret, err := GetTLSSecret(secret.Data)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Error reading TLS configuration", zap.Error(err))
+	} else {
+		// For now just override the previous config.
+		r.tlsCert = tlsSecret.TLSCertificate
 	}
-	// For now just override the previous config.
-	r.tlsCert = tlsSecret.TLSCertificate
 }