This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make clear that it is not a suppression error mechanism
Resolves #60
- Loading branch information
1 parent
295ab49
commit 87e408d
Showing
1 changed file
with
15 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87e408d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, was there a PR for this change? From here, given that this repository is pretty widely watched, if we could make changes via PRs rather than just landing patches, to allow broader participation.
87e408d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#60 was closed with it, so anyone watching the repo definitely got the notification.
87e408d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I’ll open PRs for the next modifications.
87e408d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb Yeah, that's how I arrived here. A nice thing about PRs is that we can also make review comments. I'm not suggesting a requirement for all cases, but here, we have a bunch of people working together on this particular proposal.