Add PromiseCapability wrapper around sync dispose used in an await using
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
added
needs-consensus
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/218. |
This was referenced Mar 22, 2024
rbuckton
added
the
has-consensus
ljharb
added a commit
to es-shims/DisposableStack
that referenced
this pull request
Apr 10, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #216 (comment), this adds a
PromiseCapabilityto the wrapper function created around a@@disposemethod read by anawait usingdeclaration to ensure that any errors thrown by@@disposeare not thrown synchronously. This is in keeping with the mechanism used in%AsyncFromSyncIteratorPrototype%.next().