Normative: Source Phase Imports rebased to Import Attributes #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Import Attributes proposal * `npm run format` * Updates from review * Changes from review * Do not re-define ImportDeclaration * Add `assert` deprecated syntax to `export ... from` * Remove `[no LineTerminator here]` before `with` * Use optional symbols to reduce grammar * Update ImportEntries and ExportEntry to use ModuleRequest Records * Review from Michael * Replace AttributeKey with LiteralPropertyName * Separate ModuleRequest and LoadedModuleRequest fields * Validate attrs when lodaing deps and not when parsing * Merge `AssertClause` into `WithClause`, and fix missing SDOs * Fix type annotation * Simplify AttributesKeyword * Reviews * Review * Remove support for float and bigint literal keys * Update wording
guybedford
force-pushed
the
source-phase-imports
branch
2 times, most recently
from
952c7d6
to
7468100
Compare
ljharb
added
normative change
guybedford
force-pushed
the
source-phase-imports
branch
from
7468100
to
265ddac
Compare
|
Since previously, test-262 tests were added in tc39/test262#3980, tc39/test262#4252 and tc39/test262#4277. |
guybedford
force-pushed
the
source-phase-imports
branch
from
265ddac
to
8550dd0
Compare
ljharb
added
has test262 tests
and removed
needs test262 tests
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest PR diff for the Stage 3 Source Phase Imports proposal, based to the latest commit on #3057.
This PR replaces #3094, since work moved back into the specification repo since then with further changes which are brought back here.
All review feedback on the previous PR was formerly also upstreamed, so that all review comments should be addressed. This sync was previously done in tc39/proposal-source-phase-imports#60 in April 2024, so included the latest comments.
To summarize the outstanding discussions from that PR here:
ModuleRequesthandling, which should all be resolved by the complete import attributes rebase since that introduces this record.Formerly we had a review approval from @syg as well (#3094 (review)) down to some questions in the threads.
This PR forms the new base for all subsequent module harmony proposals going forward including Import Defer and the ESM Phase Imports proposals, as such it will be important to ensure it is maintained towards Stage 4 progression.