Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix warnings #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ex_closeio/base.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ defmodule ExCloseio.Base do
request_and_retry(url_part, api_key, params, {:attempt, 1})
end

def request_and_retry(url_part, api_key, params, {:error, reason}), do: {:error, reason}
def request_and_retry(_url_part, _api_key, _params, {:error, reason}), do: {:error, reason}
def request_and_retry(url_part, api_key, params, {:attempt, attempt}) do
auth = set_basic_auth(api_key)

Expand Down
6 changes: 3 additions & 3 deletions lib/ex_closeio/resources/report.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ defmodule ExCloseio.Report do

# OPTIONS [date_start, date_end, user_id]
def activities(params, api_key \\ :global) do
get("/report/activity/#{get_org_id}/", api_key, params)
get("/report/activity/#{get_org_id()}/", api_key, params)
end

# OPTIONS [date_start, date_end, user_id]
def sent_emails(params, api_key \\ :global) do
get("/report/sent_email/#{get_org_id}/", api_key, params)
get("/report/sent_email/#{get_org_id()}/", api_key, params)
end

# OPTIONS [date_start, date_end]
def lead_status(params, api_key \\ :global) do
get("/report/statuses/lead/#{get_org_id}/", api_key, params)
get("/report/statuses/lead/#{get_org_id()}/", api_key, params)
end

defp get_org_id do
Expand Down
12 changes: 6 additions & 6 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ defmodule ExCloseio.Mixfile do
elixir: "~> 1.3",
build_embedded: Mix.env == :prod,
start_permanent: Mix.env == :prod,
description: description,
package: package,
deps: deps]
description: description(),
package: package(),
deps: deps()]
end

def application do
Expand All @@ -26,9 +26,9 @@ defmodule ExCloseio.Mixfile do
end

defp description do
"""
Close.io client library for Elixir.
"""
"""
Close.io client library for Elixir.
"""
end

defp package do
Expand Down
2 changes: 1 addition & 1 deletion mix.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
"metrics": {:hex, :metrics, "1.0.1", "25f094dea2cda98213cecc3aeff09e940299d950904393b2a29d191c346a8486", [:rebar3], []},
"mimerl": {:hex, :mimerl, "1.0.2", "993f9b0e084083405ed8252b99460c4f0563e41729ab42d9074fd5e52439be88", [:rebar3], []},
"poison": {:hex, :poison, "2.2.0", "4763b69a8a77bd77d26f477d196428b741261a761257ff1cf92753a0d4d24a63", [:mix], []},
"ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.0", "edee20847c42e379bf91261db474ffbe373f8acb56e9079acb6038d4e0bf414f", [:rebar, :make], []}}
"ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.0", "edee20847c42e379bf91261db474ffbe373f8acb56e9079acb6038d4e0bf414f", [:make, :rebar], []}}