Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs): use correct arg name for unwatch #857

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix(fs): use correct arg name for unwatch #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c14fa3
fix(fs): use correct arg name for unwatch
amrbashir Dec 28, 2023
70dcc62
fmt
amrbashir Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/fs-unwtach-rid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"fs-js": "patch"
---

Fix `invalid args id for command unwatch` error when trying to unwatch a previously watched file or directory.
4 changes: 2 additions & 2 deletions plugins/fs/guest-js/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,8 +1135,8 @@ type DebouncedEvent =
*/
type UnwatchFn = () => void;

async function unwatch(id: number): Promise<void> {
await invoke("plugin:fs|unwatch", { id });
async function unwatch(rid: number): Promise<void> {
await invoke("plugin:fs|unwatch", { rid });
}

/**
Expand Down
2 changes: 1 addition & 1 deletion plugins/fs/src/api-iife.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading