Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logos #604

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix logos #604

merged 3 commits into from
Sep 14, 2023

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Sep 14, 2023 •
edited
Loading

This PR fixes the Impierce and CrabNebula logos in both light and dark settings.

Light Dark
image image

It follows the following orders of precedence:

  • Assumes light mode, logos are brand colors
  • If client device is in dark mode, logos are white
  • If GitHub settings are set either light or dark, client device settings are overridden and GitHub wins

@TejasQ TejasQ changed the base branch from v1 to v2 September 14, 2023 12:21
@TejasQ TejasQ closed this Sep 14, 2023
@TejasQ TejasQ reopened this Sep 14, 2023
@TejasQ TejasQ marked this pull request as ready for review September 14, 2023 13:23
@TejasQ TejasQ requested a review from a team as a code owner September 14, 2023 13:23
@TejasQ TejasQ force-pushed the fix-logos branch 2 times, most recently from a2503cf to f839d1b Compare September 14, 2023 13:28
@JonasKruckenberg
Copy link
Member

JonasKruckenberg commented Sep 14, 2023 •
edited
Loading

You need to sign your commit ;) here's a guide that explains how to do it

@TejasQ
Copy link
Contributor Author

TejasQ commented Sep 14, 2023

I know how commit signing works lol, all good.

@lucasfernog lucasfernog merged commit 8e8ba52 into tauri-apps:v2 Sep 14, 2023
3 checks passed
@TejasQ TejasQ deleted the fix-logos branch September 14, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKruckenberg JonasKruckenberg JonasKruckenberg approved these changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TejasQ @JonasKruckenberg @lucasfernog