Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding semver compatibility check for Windows and Linux #502

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

matthme
Copy link
Contributor

@matthme matthme commented Jul 17, 2023

Addressing #494 . This PR is assuming that this is desired default behavior. If it should rather be hidden behind a feature flag, I can try to add that.

@matthme matthme requested a review from a team as a code owner July 17, 2023 08:29
@FabianLars FabianLars requested a review from amrbashir July 17, 2023 10:00
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks alright, but I am not sure I like the compatibility thing though, I think mismatched versions, even if its a patch version shouldn't launch a different version.

However, I think this maybe a desired behavior for some people so I'd suggest:

  1. Add a behavior enum
    enum LaunchBehavior {
    	Same,
    	#[cfg(feature = "compatible")]
    	Compatible
    }
  2. Add a builder for the plugin that will have a method to specify which behavior they need
  3. make the behavior that requires semver behind a feature flag just to not add unnecessary dependencies for default behavior.

does that sound alright?

@matthme
Copy link
Contributor Author

matthme commented Jul 17, 2023

Okay, I will try to add that when I have some time.

@qlaffont
Copy link

Any update on this one ?

@matthme
Copy link
Contributor Author

matthme commented Sep 29, 2023

I did not have time to implement the feature flag as it will probably take quite some time and I had lots of other things on my plate so far. For now I'm using my fork instead for my projects: https://github.com/matthme/plugins-workspace/tree/single-instance-semver maybe that's useful for you as well.

@FabianLars
Copy link
Member

@amrbashir would it be alright to have the feature flag itself change the behavior?

@amrbashir
Copy link
Member

I guess so yeah

@FabianLars
Copy link
Member

coolio. mainly asking cause i'm lazy 🙃

@FabianLars FabianLars requested a review from amrbashir February 28, 2024 21:12
@FabianLars FabianLars force-pushed the single-instance-semver branch from 4dc4461 to e8986e2 Compare February 28, 2024 22:09
@FabianLars FabianLars dismissed amrbashir’s stale review April 15, 2024 13:51

choo choo, i'm merging all v1 prs, get out of my way :P

@FabianLars FabianLars merged commit 4210cf3 into tauri-apps:v1 Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants