Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs): add the size method to get the size of a file or directory #2095

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

ayangweb
Copy link
Contributor

@FabianLars Help me refine it a bit more, thanks!

@ayangweb ayangweb requested a review from a team as a code owner November 25, 2024 14:45
@ayangweb ayangweb changed the title feat(fs): add the size method to get the size of a file or directory. feat(fs): add the size method to get the size of a file or directory Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Package Changes Through 7709f2b

There are 16 changes which include fs with minor, upload with minor, upload-js with minor, deep-link with patch, deep-link-js with patch, persisted-scope with minor, log-plugin with patch, log-js with patch, fs-js with patch, http with patch, localhost with minor, opener with major, opener-js with major, positioner-js with minor, positioner with minor, sql with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.5 2.0.6
api-example-js 2.0.2 2.0.3
deep-link-example-js 2.0.0 2.0.1
deep-link 2.0.1 2.0.2
deep-link-js 2.0.0 2.0.1
fs 2.0.3 2.1.0
fs-js 2.0.2 2.0.3
dialog 2.0.3 2.0.4
opener 1.0.0 2.0.0
opener-js 1.0.0 2.0.0
http 2.0.3 2.0.4
localhost 2.0.1 2.1.0
log-plugin 2.0.2 2.0.3
log-js 2.0.0 2.0.1
persisted-scope 2.0.3 2.1.0
positioner 2.0.2 2.1.0
positioner-js 2.0.1 2.1.0
single-instance 2.0.1 2.0.2
sql 2.0.2 2.0.3
upload 2.1.0 2.2.0
upload-js 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just a few small thinks. Also, we'll need a changefile like https://github.com/tauri-apps/plugins-workspace/blob/v2/.changes/fix-fs-scope-escape-paths.md

plugins/fs/guest-js/index.ts Outdated Show resolved Hide resolved
plugins/fs/src/commands.rs Outdated Show resolved Hide resolved
plugins/fs/guest-js/index.ts Outdated Show resolved Hide resolved
@ayangweb
Copy link
Contributor Author

ayangweb commented Nov 26, 2024

Thank you for your guidance, I've revised it, and you can look at it again!

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review the rest later, I'm just on a phone rn

.changes/add-fs-size.md Outdated Show resolved Hide resolved
.changes/add-fs-size.md Outdated Show resolved Hide resolved
@FabianLars
Copy link
Member

the errors should be gone once you add the command to the invoke_handler list https://github.com/ayangweb/plugins-workspace/blob/fs-size/plugins/fs/src/lib.rs#L396

@ayangweb
Copy link
Contributor Author

the errors should be gone once you add the command to the invoke_handler list https://github.com/ayangweb/plugins-workspace/blob/fs-size/plugins/fs/src/lib.rs#L396

ok, I added it!

amrbashir
amrbashir previously approved these changes Nov 26, 2024
@amrbashir
Copy link
Member

looks like you also need to run pnpm build and potentially pnpm format

@ayangweb
Copy link
Contributor Author

looks like you also need to run pnpm build and potentially pnpm format

Okay, I executed and submitted it!

@amrbashir amrbashir requested a review from FabianLars November 26, 2024 11:44
@amrbashir amrbashir merged commit fef76bd into tauri-apps:v2 Nov 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants