Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tauri-plugin-opener #2019

Merged
merged 36 commits into from
Nov 19, 2024
Merged

feat: add tauri-plugin-opener #2019

merged 36 commits into from
Nov 19, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Nov 7, 2024

closes #999
closes #1045

@amrbashir amrbashir requested a review from a team as a code owner November 7, 2024 20:07
@amrbashir
Copy link
Member Author

marking as a draft until I release an empty packages on crates.io and npm

@amrbashir amrbashir marked this pull request as draft November 7, 2024 20:07
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Package Changes Through 23143e9

There are 12 changes which include upload with minor, upload-js with minor, deep-link with patch, deep-link-js with patch, log-plugin with patch, log-js with patch, fs with patch, fs-js with patch, localhost with minor, opener with major, opener-js with major, sql with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.5 2.0.6
api-example-js 2.0.2 2.0.3
deep-link-example-js 2.0.0 2.0.1
deep-link 2.0.1 2.0.2
deep-link-js 2.0.0 2.0.1
fs 2.0.3 2.0.4
fs-js 2.0.2 2.0.3
dialog 2.0.3 2.0.4
opener 1.0.0 2.0.0
opener-js 1.0.0 2.0.0
http 2.0.3 2.0.4
localhost 2.0.1 2.1.0
log-plugin 2.0.2 2.0.3
log-js 2.0.0 2.0.1
persisted-scope 2.0.3 2.0.4
single-instance 2.0.1 2.0.2
sql 2.0.2 2.0.3
upload 2.1.0 2.2.0
upload-js 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir marked this pull request as ready for review November 12, 2024 00:40
plugins/opener/Cargo.toml Outdated Show resolved Hide resolved
plugins/opener/guest-js/index.ts Outdated Show resolved Hide resolved
plugins/opener/src/scope.rs Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member Author

amrbashir commented Nov 14, 2024

From testing, when I click on the links in the example, the link gets opened twice, but from #2051, it seems like it's not a problem from this PR?

yeah, this was a bug I noticed with old loop implementation, it is fixed in this PR and I will open a PR to fix #2051 later

Copy link
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is fixed in this PR

It still seem to happen in this PR to me

plugins/opener/guest-js/index.ts Outdated Show resolved Hide resolved
plugins/opener/src/lib.rs Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member Author

it is fixed in this PR

It still seem to happen in this PR to me

weird, I can reproduce in this PR, anyways I am looking into it, seems not related to the implementation, might be a bug in tauri, still searching...

@Legend-Master
Copy link
Contributor

Seems like there're some problems about the permissions?

image

@amrbashir
Copy link
Member Author

fixed

@Legend-Master
Copy link
Contributor

Need to get some sleep, will get back to this tomorrow

@amrbashir
Copy link
Member Author

double events are fixed in tauri-apps/wry#1418, so this PR can move forward.

Copy link
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only tested on Windows though

@amrbashir
Copy link
Member Author

@FabianLars can you give this a test on macOS? (and Linux if you want)

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on macos and wsl (don't have an actual linux system on hand rn)

@amrbashir amrbashir merged commit 383e636 into v2 Nov 19, 2024
198 checks passed
@amrbashir amrbashir deleted the feat/plugin-opener branch November 19, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shell] shell.open scope should accept regex and fs scope. [shell] Show in finder/explorer
3 participants