Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): propagte some errors and avoid unwrapping #1294

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(log): propagte some errors and avoid unwrapping #1294

merged 1 commit into from
Jul 1, 2024

Conversation

amrbashir
Copy link
Member

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner May 7, 2024 14:58
@amrbashir amrbashir requested a review from FabianLars May 9, 2024 16:43
FabianLars
FabianLars approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i could swear i merged this already, like i would've bet money on it if you asked me... sorriiii

@FabianLars FabianLars merged commit 862c42a into v1 Jul 1, 2024
5 of 6 checks passed
@FabianLars FabianLars deleted the fix/log/unwrapping branch July 1, 2024 13:31
@amrbashir
Copy link
Member Author

There was 2 PRs, for v2 and v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @FabianLars