Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some api for use s3 in project #37

Merged
merged 17 commits into from
Oct 11, 2024
Merged

Add some api for use s3 in project #37

merged 17 commits into from
Oct 11, 2024

Conversation

ripls56
Copy link
Member

@ripls56 ripls56 commented Oct 3, 2024

No description provided.

@ripls56 ripls56 self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 7.84314% with 94 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/server/internal/pkg/s3/s3.go 0.00% 42 Missing ⚠️
apps/server/internal/app/grpc/grpc.go 0.00% 20 Missing ⚠️
apps/server/internal/pkg/migrations/migrations.go 0.00% 15 Missing ⚠️
apps/server/internal/app/app.go 0.00% 11 Missing ⚠️
apps/server/internal/pkg/s3/config.go 60.00% 2 Missing and 2 partials ⚠️
apps/server/internal/config/config.go 33.33% 2 Missing ⚠️
Flag Coverage Δ
./apps/notification 0.00% <ø> (ø)
./apps/server 7.72% <7.84%> (+0.04%) ⬆️
./libs/queue 0.00% <ø> (ø)
./libs/template 63.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/notification/cmd/notification/main.go 0.00% <ø> (ø)
apps/server/cmd/server/main.go 0.00% <ø> (ø)
apps/server/internal/grpc/interceptors/matcher.go 0.00% <ø> (ø)
apps/server/internal/pkg/notifier/account.go 72.41% <100.00%> (ø)
apps/server/internal/pkg/notifier/email.go 72.72% <ø> (ø)
libs/queue/config.go 0.00% <ø> (ø)
apps/server/internal/config/config.go 58.33% <33.33%> (+8.33%) ⬆️
apps/server/internal/pkg/s3/config.go 60.00% <60.00%> (ø)
apps/server/internal/app/app.go 0.00% <0.00%> (ø)
apps/server/internal/pkg/migrations/migrations.go 0.00% <0.00%> (ø)
... and 2 more

@ripls56 ripls56 merged commit 3c5c299 into dev Oct 11, 2024
10 checks passed
@ripls56 ripls56 deleted the feat/s3 branch October 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants