PHP 8 support (drops PHP 7.0/7.1) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-5.x Add support for Symfony 5.x
rvanlaak
reviewed
Oct 12, 2023
composer.json
Outdated
| "php": "^7.0", | ||
| "symfony/property-access": "^3.2|^4.0" | ||
| "php": "^7.2 || ^8.0", | ||
| "symfony/property-access": "^3.2 || ^4.0 || ^5.0" |
There was a problem hiding this comment.
Suggested change
| "symfony/property-access": "^3.2 || ^4.0 || ^5.0" | |
| "symfony/property-access": "^3.2 || ^4.0 || ^5.0 || ^6.0" |
There was a problem hiding this comment.
Updated to support Symfony 7 as well.
|
@havvg any capacity available to bring this library to the modern age of PHP 8.x ? Happy to help where needed, but merging this PR and releasing it seems to be a first step. |
|
@edudobay I see tests don't run, so any chance you could add the Github CI yaml files for that? |
|
@rvanlaak Sure! Will do this later today. |
|
I think GitHub Actions need to be enabled in this repository, but in my fork the tests are running: https://github.com/edudobay/doctrine-nullable-embeddable/actions/runs/6499755366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #7 (approved but not yet merged) to add PHP 8 support, dropping support for PHP 7.0/7.1.