Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library compilation errors #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

amotl
Copy link

@amotl amotl commented May 23, 2023

Dear Paul,

thanks a stack for conceiving this library. We are using it over at https://github.com/hiveeyes/arduino, and just discovered the corresponding firmwares won't build on recent PlatformIO environments 1.

It's essentially about the issue @gibman reported at GH-3. This patch intends to fix it.

With kind regards,
Andreas.

Compiling .pio/build/nodemcu/lib9d8/TextFinder/TextFinder.cpp.o
.pio/libdeps/nodemcu/TextFinder/TextFinder.cpp: In member function 'float TextFinder::getFloat()':
.pio/libdeps/nodemcu/TextFinder/TextFinder.cpp:214:5: error: no return statement in function returning non-void [-Werror=return-type]
  214 |     }
      |     ^
.pio/libdeps/nodemcu/TextFinder/TextFinder.cpp: In member function 'float TextFinder::getFloat(char)':
.pio/libdeps/nodemcu/TextFinder/TextFinder.cpp:222:13: warning: unused variable 'fValue' [-Wunused-variable]
  222 |       float fValue;
      |             ^~~~~~
cc1plus: some warnings being treated as errors

Footnotes

  1. https://github.com/hiveeyes/arduino/actions/runs/5062446319/jobs/9087977561#step:10:149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant