Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aide): sync axum router differences #90

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat(aide): sync axum router differences #90

merged 1 commit into from
Nov 30, 2023

Conversation

tamasfe
Copy link
Owner

@tamasfe tamasfe commented Nov 29, 2023 •
edited
Loading

Aligns some trait bounds and missing methods with axum's router types. Also added missing Clone on ApiMethodRouter.

Closes #86, closes #89.

@tamasfe tamasfe requested a review from Wicpar November 29, 2023 12:13
Wicpar
Wicpar approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@Wicpar Wicpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however the layer functionality would benefit from having some mechanism to modify and inject operations, but that is outside of the scope of the PR

gitlab-dfinity pushed a commit to dfinity/ic that referenced this pull request Nov 30, 2023
@michael-weigelt
Merge branch 'mwe/openapi' into 'master'
296cff0 
feat: [VER-2588] OpenApi Documentation for PocketIC

This MR adds OpenAPI documentation to all endpoints. The documentation is available at \<url\>/api.json. 

The documentation will be **incomplete** until the issue below is merged, and the dependency (aide) has been bumped to the fixed version. 
tamasfe/aide#90 

See merge request dfinity-lab/public/ic!16296
@tamasfe
Copy link
Owner Author

tamasfe commented Nov 30, 2023

Looks good, however the layer functionality would benefit from having some mechanism to modify and inject operations, but that is outside of the scope of the PR

Agreed, this is just some grunt work to catch up with axum, I don't have the capacity for designing/adding more features atm.

@tamasfe tamasfe merged commit 6eaa058 into master Nov 30, 2023
1 check passed
@tamasfe tamasfe deleted the feat/axum-routes-refactor branch November 30, 2023 17:45
@michael-weigelt
Copy link

Thanks for the quick fix. When can I expect a release from here, is there a schedule or some guideline?

@tamasfe
Copy link
Owner Author

tamasfe commented Dec 4, 2023

Hi @Wicpar, do you perhaps have some time for a release? I forgot about it and atm I'm struggling with covid so I don't know when I'll get back to this. The release should be pretty much ready afaik.

@Wicpar
Copy link
Collaborator

Wicpar commented Dec 4, 2023

i didn't see you removed the typed headers, i put them back as it was breaking for me. I'll release it, any other removals i might have missed that i have to go over first ?

@tamasfe
Copy link
Owner Author

tamasfe commented Dec 4, 2023

Ah, I didn't mean to remove anything intentionally, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wicpar Wicpar Wicpar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApiMethodRouter does not implement Clone Route layers for route functions
3 participants
@tamasfe @michael-weigelt @Wicpar