Fixes authentication on get_object_or_error #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a change on authentication verification when calling
get_object_or_error
.Previously, authentication was checked only... if object was not found.
A typical example that has highlighted this problem: before this commit if a user has generated a report URL, then this URL was available to anyone (even anonymous users) for private projects.
I think this can be considered as a breaking change (because authentication is now required for affected endpoints)