Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes authentication on get_object_or_error #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

privat-eco
Copy link

@privat-eco privat-eco commented Apr 3, 2024

This commit introduces a change on authentication verification when calling get_object_or_error.

Previously, authentication was checked only... if object was not found.

A typical example that has highlighted this problem: before this commit if a user has generated a report URL, then this URL was available to anyone (even anonymous users) for private projects.

I think this can be considered as a breaking change (because authentication is now required for affected endpoints)

This commit makes authentication required to access objects with `get_object_or_error`.

Previously, authentication was checked only... if object was not found
@bameda
Copy link
Member

bameda commented Apr 3, 2024

Hi @privat-eco

With your changes, the API can only be used by registered and authenticated users. Anonymous users can't access to Taiga to see public content.

By reviewing the test results you can see how tests for anonymous users fail (always returns 401).

For greater security of reports from the application, it is necessary to implement a different, more complex system. Sometimes the reports may be read by an application and access needs to be open (only those who know the url can access it).

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants