Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): add styles entrypoint to exports of package.json #9813

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

nsbarsukov
Copy link
Member

The same logic as inside @taiga-ui/core

"exports": {
"./styles/*": "./styles/*"
},

@nsbarsukov nsbarsukov self-assigned this Nov 22, 2024
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 22, 2024 09:58
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 22, 2024 09:58
Copy link

lumberjack-bot bot commented Nov 22, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 3bc600c):

https://taiga-previews-demo--pr9813-legacy-styles-export-demo-3ckuh0m0.web.app

(expires Sat, 23 Nov 2024 10:02:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Nov 22, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
304.37KB +10%
demo/browser/vendor.(hash).js
260.09KB +10%
demo/browser/runtime.(hash).js
44.03KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.34MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

passed  972 passed
flaky  1 flaky

Details

report  Open report ↗︎
stats  973 tests across 69 suites
duration  11 minutes, 25 seconds
commit  3bc600c

Flaky tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/icon

@splincode splincode merged commit eee448d into main Nov 22, 2024
28 checks passed
@splincode splincode deleted the legacy-styles-export branch November 22, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants