Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): missing migration schematic for mixins from @taiga-ui/legacy/styles/taiga-ui-local #9802

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

nsbarsukov
Copy link
Member

@import 'mixins/mixins.less';
@import 'mixins/textfield.less';

@nsbarsukov nsbarsukov self-assigned this Nov 20, 2024
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 20, 2024 10:52
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 20, 2024 10:52
Copy link

lumberjack-bot bot commented Nov 20, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Visit the preview URL for this PR (updated for commit b89c230):

https://taiga-previews-demo--pr9802-legacy-mixin-imports-migra-dxpi9zm2.web.app

(expires Thu, 21 Nov 2024 12:43:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Nov 20, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
304.37KB +10%
demo/browser/vendor.(hash).js
260.09KB +10%
demo/browser/runtime.(hash).js
44.03KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.34MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Playwright test results

failed  1 failed
passed  972 passed

Details

report  Open report ↗︎
stats  973 tests across 69 suites
duration  11 minutes, 46 seconds
commit  b89c230

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/icon

@nsbarsukov nsbarsukov merged commit ca9e2e0 into main Nov 22, 2024
25 of 26 checks passed
@nsbarsukov nsbarsukov deleted the legacy-mixin-imports-migration branch November 22, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants