Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix custom hint #9776

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(core): fix custom hint #9776

merged 1 commit into from
Nov 20, 2024

Conversation

vladimirpotekhin
Copy link
Member

Fixes #9756

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner November 18, 2024 13:33
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team November 18, 2024 13:33
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 18, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit ba1d549):

https://taiga-previews--pr9776-fix-custom-hint-b92rmzyp.web.app

(expires Tue, 19 Nov 2024 13:37:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 18, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 304.29KB +10%
✅ demo/browser/vendor.(hash).js
 260.09KB +10%
✅ demo/browser/runtime.(hash).js
 44.03KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.34MB (+24B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@nsbarsukov nsbarsukov merged commit ae83d2d into main Nov 20, 2024
27 of 28 checks passed
@nsbarsukov nsbarsukov deleted the fix-custom-hint branch November 20, 2024 08:03
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Custom Hint does not work
3 participants
@vladimirpotekhin @splincode @nsbarsukov