Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo-cypress): screenshot testing for component tests #9290

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

nsbarsukov
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Oct 1, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@@ -3,7 +3,7 @@
class="fade"
>
<div tuiFade>Very long value in chip</div>
<div>{{ 123435 | tuiAmount: 'RUB' | async }}</div>
<div>{{ 123456 | tuiAmount: 'RUB' | async }}</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to debug that Playwright screenshot testing still properly works in CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works 👍
Снимок экрана 2024-10-01 в 16 14 27

@@ -3,6 +3,7 @@
"private": true,
"devDependencies": {
"@nx/cypress": "19.8.2",
"cypress": "13.15.0"
"cypress": "13.15.0",
"cypress-image-diff-js": "2.2.1"
Copy link
Member Author

@nsbarsukov nsbarsukov Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Cypress documentation:

Visual regression testing plugin maintained by Department for International Trade - UK Gov.

cypress-image-diff has active support for the last 4 years

@@ -156,7 +156,7 @@
"ng-packagr": "16.2.3",
"ngx-highlightjs": "10.0.0",
"nx": "19.8.2",
"rxjs": "7.5.0",
"rxjs": "7.8.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.5.0 is not compatible with "moduleResolution": "bundler"

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Visit the preview URL for this PR (updated for commit 7df8f9d):

https://taiga-previews--pr9290-component-testing-sc-iu3wlhef.web.app

(expires Wed, 02 Oct 2024 13:34:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 1, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.33KB (+198B +0.08%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
287.9KB +10%
demo/browser/runtime.(hash).js
42.74KB +10%
demo/browser/styles.(hash).css
16.25KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +199B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.09MB (+229B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov changed the title [WIP] chore(demo-cypress): screenshot testing for component tests chore(demo-cypress): screenshot testing for component tests Oct 1, 2024
@nsbarsukov nsbarsukov merged commit a965dd5 into main Oct 1, 2024
25 of 26 checks passed
@nsbarsukov nsbarsukov deleted the component-testing-screenshot branch October 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants