introduce a simple readiness probe that doesn't check bootstrapped st… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus
Recently we have seen on mondaynet the node's RPC subsystem become
unresponsive, but the node does not crash.
We normally have a readiness probe to get alerted when this happens.
But the readiness probe is overkill: it checks whether the chain is
bootstrapped by measuring the age of the head block, failing if it's
over 10 minutes.
We don't want this on test networks generally, but especially on
mondaynet. After activation, we wait for the website to be published,
other participants to come online, and quorum to be met.
If we had this probe, the chain would be marked as unbootstrapped and
stop responding to RPC and p2p, then we would never get quorum.
But we still want to be alerted when the RPC subsystem is down.
I'm introducing 2 readiness probe settings:
* `bootstrapped_readiness_probe`: identical to existing
`readiness_probe`
* `rpc_readiness_probe`: checks for RPC only
By default, they are on. So for mondaynet, the following should be set:
```
nodes:
nodex:
bootstrapped_readiness_probe: false
```
craigbuckler
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atus
Recently we have seen on mondaynet the node's RPC subsystem become unresponsive, but the node does not crash.
We normally have a readiness probe to get alerted when this happens.
But the readiness probe is overkill: it checks whether the chain is bootstrapped by measuring the age of the head block, failing if it's over 10 minutes.
We don't want this on test networks generally, but especially on weeklynet. After activation, we wait for the website to be published, other participants to come online, and quorum to be met.
If we had this probe, the chain would be marked as unbootstrapped and stop responding to RPC and p2p, then we would never get quorum.
But we still want to be alerted when the RPC subsystem is down.
I'm introducing 2 readiness probe settings:
bootstrapped_readiness_probe: identical to existingreadiness_proberpc_readiness_probe: checks for RPC onlyBy default, they are on. So for mondaynet, the following should be set: