Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New coat of paint for the generated output #27

Merged
merged 11 commits into from
Dec 4, 2024
Merged

New coat of paint for the generated output #27

merged 11 commits into from
Dec 4, 2024

Conversation

tacgomes
Copy link
Owner

@tacgomes tacgomes commented Dec 3, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/investir/cli.py 100.00% <100.00%> (ø)
src/investir/config.py 100.00% <100.00%> (ø)
src/investir/prettytable.py 100.00% <100.00%> (ø)
src/investir/taxcalculator.py 100.00% <100.00%> (ø)
src/investir/trhistory.py 100.00% <100.00%> (ø)
src/investir/utils.py 100.00% <100.00%> (ø)

@tacgomes tacgomes changed the title New coat of paint for the output generated by the different subcommands New coat of paint for the generated output Dec 3, 2024
@tacgomes tacgomes marked this pull request as ready for review December 3, 2024 21:54
Update the methods that were responsible to print tables in `TrHistory`
and `TaxCalculator` classes to return a `PrettyTable` instance and
delegate the printing act itself to the cli module.
Improve the appearance of tables by implementing the following changes:
* Avoid rendering most of the frame for a table.
* Make the text on field titles to appear stylised in bold.
* Remove the minimal width for the "Name" field.
* Show dates in a format more common in the United Kingdom.
@tacgomes tacgomes merged commit e316ed9 into main Dec 4, 2024
29 checks passed
@tacgomes tacgomes deleted the next branch December 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants