Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove lodash #97

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

simenandre
Copy link
Member

@simenandre simenandre commented Dec 29, 2020

We need to refactor product pages before this can be merged.

fixes #92
re #98

@todo
Copy link

todo bot commented Dec 29, 2020

This is not the way we should handle monetary values.

// TODO: This is not the way we should handle monetary values.
input.price = Number(values.price.replace(',', '.')) * 100;
}
if (values.categories) {
input.categories = ((values.categories as unknown) as TagProps[]).map(
({ id, name }) => ({ id: id as number, title: name })


This comment was generated by todo based on a TODO comment in 74276d1 in #97. cc @tabetalt.

@simenandre simenandre added the blocked Work can't continue label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work can't continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lodash
1 participant