feat(experimental): future module using taint #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juliusmarminge
commented
Jan 25, 2024
| @@ -1,10 +1,13 @@ | |||
| import "./app/env.js"; | |||
| // import "./app/env.js"; | |||
There was a problem hiding this comment.
can't import here since taint isn't "defined" yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
TODO
try-catch, even though it worked without them, we got some errors saying taint was not a function, worked around by wrapping in try catch. I assume it's different runtimes at play here that doesn't like eachotherChanges
Adds a
/futuremodule to the nextjs package that taints the server variables. This makes sure server variables are not leaked by enforcing:Demo
taint.mp4