chore: update trpc to use server caller #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
cc @RhysSullivan iirc you preffered the server caller approach so I think you'll like this change. Reason I didn't like this before was the nested awaits required when you had async context (see trpc/trpc#5244 (comment)) , but that's fixed by allowing the createCaller function be passed a function |
juliusmarminge
force-pushed
the
12-29-update-trpc
branch
from
8615618 to
54ad9de
Compare
juliusmarminge
force-pushed
the
12-29-update-trpc
branch
from
54ad9de to
b53e6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves server caller to use
createCallernow that we've added the ability to pass it a createContext functionNote
I will wait for PR (trpc/trpc#5244) to be merged then revert to using the
nexttag