Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a Dockerfile #100

wants to merge 1 commit into from

Conversation

rkdarst
Copy link

@rkdarst rkdarst commented May 4, 2021

  • I wouldn't say I like docker, but I didn't want to install npm on my
    own computer to build this, so created a quick Dockerfile. It seems
    to work for me, so I may as well make it useful to others.
  • This is capable of running as-is, but I also used it to extract the
    built files out and host them elsewhere.
  • I now realize there was a simpler way to do this (get built files
    from the gh-pages branch), so I probably won't use this anymore.
    Still, maybe useful to someone? I have no problems if this is
    rejected as extra complexity.
  • Review
    • I wouldn't call myself a docker expert, so a review of that aspect
      would be welcome.

- I wouldn't say I like docker, but I didn't want to install npm on my
  own computer to build this, so created a quick Dockerfile.  It seems
  to work for me, so I may as well make it useful to others.
- This is capable of running as-is, but I also used it to extract the
  built files out and host them elsewhere.
- I now realize there was a simpler way to do this (get built files
  from the gh-pages branch), so I probably won't use this anymore.
  Still, maybe useful to someone?  I have no problems if this is
  rejected as extra complexity.
- Review
  - I wouldn't call myself a docker expert, so a review of that aspect
    would be welcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant