Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nkf as a dependency #69

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add nkf as a dependency #69

merged 1 commit into from
Jun 3, 2024

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Jun 3, 2024

Since Ruby 3.3.0, RubyGems and Bundler warn if users require the gems that will become the bundled gems in the future version of Ruby.
Please see the "Standard library updates" section for the details. https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

gmo uses nkf. This fixes the following warning.

gmo-payment-ruby/gmo-payment-ruby/lib/gmo.rb:2: warning: nkf was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec.

Ref: https://github.com/t-k/gmo-payment-ruby/actions/runs/9106594362/job/25034049847#step:4:6

Since Ruby 3.3.0, RubyGems and Bundler warn if users do require the
gems that will become the bundled gems in the future version of Ruby.
Please see the "Standard library updates" section for the details.
https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

`gmo` uses `nkf`. This fixes the following warning.

```
gmo-payment-ruby/gmo-payment-ruby/lib/gmo.rb:2: warning: nkf was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec.
```

Ref:  https://github.com/t-k/gmo-payment-ruby/actions/runs/9106594362/job/25034049847#step:4:6
@y-yagi y-yagi marked this pull request as ready for review June 3, 2024 08:11
@jiikko
Copy link
Collaborator

jiikko commented Jun 3, 2024

thanks!!!!!!!

@jiikko jiikko merged commit fb0abb5 into t-k:master Jun 3, 2024
6 checks passed
@y-yagi y-yagi deleted the fix-dependency branch June 3, 2024 09:40
@y-yagi
Copy link
Contributor Author

y-yagi commented Jun 14, 2024

@jiikko
Sorry to ping you, but do you have a plan to release the new version? This message always shows (e.g. Run rails console) and it's a little bothering.

$ ./bin/rails c
/home/yyagi/.rbenv/versions/3.3.3/lib/ruby/gems/3.3.0/gems/gmo-0.5.6/lib/gmo.rb:2: warning: nkf was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec. Also contact author of gmo-0.5.6 to add nkf into its gemspec.
Loading development environment (Rails 7.1.3.4)

@jiikko
Copy link
Collaborator

jiikko commented Jun 14, 2024

Oh... I'll do it tonight!

@jiikko jiikko mentioned this pull request Jun 14, 2024
@jiikko
Copy link
Collaborator

jiikko commented Jun 14, 2024

@y-yagi
I have released it! 🙇
https://rubygems.org/gems/gmo/versions/0.5.7

@y-yagi
Copy link
Contributor Author

y-yagi commented Jun 15, 2024

@jiikko
Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants