Skip to content

Improve code quality #4

Improve code quality

Improve code quality #4

Triggered via pull request December 4, 2024 11:55
@jensschuppejensschuppe
synchronize #3
qa
Status Failure
Total duration 58s
Artifacts

phpstan.yml

on: pull_request
Matrix: phpstan
Fit to window
Zoom out
Zoom in

Annotations

46 errors and 2 warnings
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/AbstractHiorgApiAction.php#L79
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L68
Parameter #2 $params of static method Civi::queue() expects array{type: string, is_autorun: bool, reset: bool, is_persistent: bool}, array{type: 'Sql', reset: false} given.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L111
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() has CRM_Core_Exception in PHPDoc @throws tag but it's not thrown.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() return type has no value type specified in iterable type array.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L152
Call to static method get() on an unknown class Civi\Api4\ConfigProfile.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L44
Cannot call method getAusbildungen() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L46
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L90
Cannot call method getHelferstunden() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 7.4 prefer-stable: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L95
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractHiorgApiAction.php#L79
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L68
Parameter #2 $params of static method Civi::queue() expects array{type: string, is_autorun: bool, reset: bool, is_persistent: bool}, array{type: 'Sql', reset: false} given.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L111
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() has CRM_Core_Exception in PHPDoc @throws tag but it's not thrown.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() return type has no value type specified in iterable type array.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L152
Call to static method get() on an unknown class Civi\Api4\ConfigProfile.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L44
Cannot call method getAusbildungen() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L46
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L90
Cannot call method getHelferstunden() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 8.3 prefer-lowest: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L95
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 8.3 prefer-stable
The job was canceled because "_7_4_prefer-stable" failed.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/AbstractHiorgApiAction.php#L79
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L68
Parameter #2 $params of static method Civi::queue() expects array{type: string, is_autorun: bool, reset: bool, is_persistent: bool}, array{type: 'Sql', reset: false} given.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L111
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() has CRM_Core_Exception in PHPDoc @throws tag but it's not thrown.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() return type has no value type specified in iterable type array.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L152
Call to static method get() on an unknown class Civi\Api4\ConfigProfile.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L44
Cannot call method getAusbildungen() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L46
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L90
Cannot call method getHelferstunden() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 8.3 prefer-stable: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L95
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 8.0 prefer-lowest
The job was canceled because "_7_4_prefer-stable" failed.
PHPStan with PHP 8.0 prefer-lowest
The operation was canceled.
PHPStan with PHP 8.0 prefer-stable
The job was canceled because "_7_4_prefer-stable" failed.
PHPStan with PHP 8.0 prefer-stable
The operation was canceled.
PHPStan with PHP 7.4 prefer-lowest
The job was canceled because "_7_4_prefer-stable" failed.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractHiorgApiAction.php#L79
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L68
Parameter #2 $params of static method Civi::queue() expects array{type: string, is_autorun: bool, reset: bool, is_persistent: bool}, array{type: 'Sql', reset: false} given.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L111
Construct empty() is not allowed. Use more strict comparison.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() has CRM_Core_Exception in PHPDoc @throws tag but it's not thrown.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L151
Method Civi\Hiorg\Api4\Action\AbstractSynchronizeAction::getConfigProfiles() return type has no value type specified in iterable type array.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/AbstractSynchronizeAction.php#L152
Call to static method get() on an unknown class Civi\Api4\ConfigProfile.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L44
Cannot call method getAusbildungen() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/GetAusbildungenApiAction.php#L46
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L90
Cannot call method getHelferstunden() on Civi\Hiorg\HiorgApi\HiorgClient|null.
PHPStan with PHP 7.4 prefer-lowest: Civi/Hiorg/Api4/Action/GetHelferstundenApiAction.php#L95
Only booleans are allowed in a ternary operator condition, string|null given.
PHPStan with PHP 7.4 prefer-stable
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
PHPStan with PHP 8.3 prefer-lowest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636