Mint v2 tokens for regular users now that all callers can accept them #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
vbustamante
approved these changes
Jan 6, 2025
jkeiser
deleted the
jkeiser/eng-2888-remember-to-make-auth-api-mint-v2-tokens-for-users-too
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just ties up a loose end: we were minting old v1 tokens for web users to ensure backwards compatibility during the upgrade. That's been working for a few weeks, so now we can switch to new-style tokens.
Testing: We already have unit tests that we're handling the v2 tokens correctly, and I've run the entire stack locally once again to make sure the module index, web app and SDF all work correctly.
This will require a deploy of the auth api, but nothing else. Existing tokens will continue to work, as well (this doesn't deprecate them or anything).