Feat/fixup e2e test #5122
Merged
Feat/fixup e2e test #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he failure condition
johnrwatson
force-pushed
the
feat/fixup-e2e-test
branch
from
5a4e050 to
13e8811
Compare
stack72
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unclear why, but this
if: ${{ failure() && github.ref == 'refs/heads/main' }}Was not triggering if there was a failure on
main, nor when I changed it to my branch did it fire correctly. I tried both conditions individually, and they both fired correctly, so something about the && not being honoured correctly with a failure condition within the github workflow.As a workaround I've moved the comparison logic for both e2e tests for branch into the shell, which should evaluate more accurately.
NB: the other comparison
if: ${{ failure() && env.last_exit_code == '53' }}has the same bug