Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdf-server): Ensure that the user is authorized before allowing any interactions #2929

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 1, 2023

If a user has been removed from a workspace, then we make a best guess at removing them from the workspace by removing them from the user_belongs_to_workspace table

That wasn't fully implemented because if they were still on the workspace then they could still interact with the diagram. If we remove the user from the user_belongs_to_workspace table then this will now check on any SDF interaction and if unathorized, the UI will kick them out

@github-actions github-actions bot added A-sdf Area: Primary backend API service [Rust] A-dal labels Nov 1, 2023
@stack72 stack72 force-pushed the paul-check-authorized-user branch 2 times, most recently from 4d5b41f to 67799c8 Compare November 1, 2023 21:53
@stack72 stack72 force-pushed the paul-check-authorized-user branch from 67799c8 to 06a92f7 Compare November 1, 2023 22:07
@stack72
Copy link
Contributor Author

stack72 commented Nov 1, 2023

bors merge

@si-bors-ng
Copy link
Contributor

si-bors-ng bot commented Nov 1, 2023

Build succeeded:

@si-bors-ng si-bors-ng bot merged commit de260a0 into main Nov 1, 2023
2 checks passed
@si-bors-ng si-bors-ng bot deleted the paul-check-authorized-user branch November 1, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dal A-sdf Area: Primary backend API service [Rust]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant