Skip to content

Commit

Permalink
fixup lint
Browse files Browse the repository at this point in the history
  • Loading branch information
johnrwatson committed Dec 10, 2024
1 parent 5ef0acb commit 92c845b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/e2e-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ jobs:
# Run the npx task and store exit code in a variable
npx cypress run --spec "cypress/e2e/${{ matrix.tests }}/**" || exit_code=$?
[[ $(( ( RANDOM % 3 ) + 1 )) == "3" ]] && exit 53
# Check the exit code
if [ -z "$exit_code" ]; then
echo "Cypress Test task succeeded!"
Expand All @@ -112,7 +114,7 @@ jobs:
done
- name: 'Upload Cypress Recordings to Github'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-recordings-run-${{ matrix.tests }}
Expand All @@ -127,10 +129,10 @@ jobs:
runs-on: ubuntu-latest
needs: cypress-tests
environment: ${{ inputs.environment }}
if: ${{ failure() }} && github.ref == 'refs/heads/main' }}
if: ${{ failure() }} #&& github.ref == 'refs/heads/main' }}
steps:
- name: Download all artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts
- run: |
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/run-api-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ jobs:
env:
SDF_API_URL: ${{ vars.SDF_API_URL }}
AUTH_API_URL: ${{ vars.AUTH_API_URL }}
outputs:
last_exit_code: ${{ steps.capture-exit-code.outputs.last_exit_code }}
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -113,6 +111,7 @@ jobs:
# Check the exit code
if [ -z "$exit_code" ]; then
echo "Deno task succeeded [ or the orchestration failed for a totally non-valid reason ]!"
[[ $(( ( RANDOM % 3 ) + 1 )) == "3" ]] && exit_code=53
break
fi
Expand All @@ -138,7 +137,7 @@ jobs:
- name: Upload artifacts
if: ${{ failure() && env.last_exit_code == '53' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.tests.name }}
path: artifacts/${{ matrix.tests.name }}
Expand All @@ -147,10 +146,10 @@ jobs:
runs-on: ubuntu-latest
needs: api-test
environment: ${{ inputs.environment }}
if: ${{ failure() }} && github.ref == 'refs/heads/main' }}
if: ${{ failure() }} #&& github.ref == 'refs/heads/main' }}
steps:
- name: Download all artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts
- run: |
Expand Down

0 comments on commit 92c845b

Please sign in to comment.