Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "security: Only show prompt when unlocking" #46

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Revert "security: Only show prompt when unlocking" #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/security.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,18 @@ extern "efiapi" fn run() -> bool {
}
};

debugln!("security state: {:?}", security_state);
// The EC will already be set to unlocked at this point, so the prompt
// must be run even when in the "Unlock" state. This is fine, as the
// prompt is for physical presence detection.

// Only show prompt when unlocking
if security_state != SecurityState::PrepareUnlock {
debugln!("security state: {:?}", security_state);
if security_state == SecurityState::Lock {
// Already locked, so do not confirm
return false;
}

// Not locked, require confirmation

let res = match Output::one() {
Ok(output) => {
let mut display = Display::new(output);
Expand Down